getDataAtRow return type modified

Tags: #<Tag:0x00007f0aff719150>

Hi Team,

when we are upgrading our handson library from version 0.10.5 to 0.35.1 we have noticed that the getDataAtRow method return type format has been changed .

0.10.5 Version

ht.getDataAtRow(0) used to return the object { id:1,name:“manoj”}

0.35.1 Version

ht.getDataAtRow(0) used to return the array [“1”,“manoj”]

when we saw the core handson js we have noticed that code has been modified.was it done to improve performance ??. if we modify the 0.35.1 handson.full.js to have old getdataatrow code .will it have any performance impact or any script failure??

instead of modifying the our entire code and its references of getDataAtRow ,we are planning to modify handson library getdataatrow method,

0.10.5 Version
this.getDataAtRow = function (row) {
return priv.settings.data[row];
};

0.35.1 Version
this.getDataAtRow = function (row) {
var data = datamap.getRange(new _src.CellCoords(row, 0), new _src.CellCoords(row, this.countCols() - 1), datamap.DESTINATION_RENDERER);

return data[0] || [];

};

Hi @mganji

Thank you for sharing a full description of an issue.
Please check if using getSourceDataAtRow(0) instead works well in your project. The getSourceDataAtRow is a new method that replaced the old behavior of getDataAtRow in versions 0.11.0-beta3 and higher.

Thanks …getSourceDataAtRow will work for us:)

Great. Thanks for the confirmation.