Autofilling in handsontable-ruleJS

hsuganuma · March 14, 2016, 5:58am

Hi
I am using handsontable-ruleJS with Handsontable Pro 1.2.0
Formula functions works fine, But I got the below error in autofilling.

Uncaught TypeError: Cannot read property '0' of undefined
  handsontable.formula.js 1:159

I can avoid this error by using handsontable v0.14 or deleting addHook calls of beforeAutofillInsidePopulate in handsontable.formula.js
But latest version and the formula autofilling feature are very important in our application.

I wanna fix handsontable.formula.js. the data[r] returns undefined value in the below steps.

github.com

handsontable/handsontable-ruleJS/blob/master/src/handsontable.formula.js#L159


      instance.render();
    }
  }
};


var beforeAutofillInsidePopulate = function (index, direction, data, deltas, iterators, selected) {
  var instance = this;


  var r = index.row,
    c = index.col,
    value = data[r][c],
    delta = 0,
    rlength = data.length, // rows
    clength = data ? data[0].length : 0; //cols


  if (value[0] === '=') { // formula


    if (['down', 'up'].indexOf(direction) !== -1) {
      delta = rlength * iterators.row;
    } else if (['right', 'left'].indexOf(direction) !== -1) {
      delta = clength * iterators.col;

I doubt the addHook interface changes on Handsontable v0.15
If you would give me some advice, it would be a tremendous help.

Thanks,
Hiroshi

aleksandra_budnik · March 14, 2016, 9:01am

Hi @hsuganuma
Please take a minute to check this subject: How to correctly install Handsontable with RuleJS
I think that it can help to understand current RuleJS state.

hsuganuma · March 14, 2016, 5:41pm

Hi @aleksandra_budnik
Yes, I understand the ruleJS isn’t supported current version.
I want to know the differences between v0.14 and v0.15 about the beforeAutofillInsidePopulate arguments.
Please let me know some migration guide in this version if you know

Thanks!

aleksandra_budnik · March 15, 2016, 8:49am

Hi @hsuganuma
Please check this release notes: https://github.com/handsontable/handsontable/releases?after=0.17.0
For example in 0.15.0 there were a lot of commits but there to note about beforeAutofillInsidePopulate https://github.com/handsontable/handsontable/compare/0.15.0...master

hsuganuma · March 15, 2016, 4:46pm

Thanks, I will investigate these commits.